Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consolidate find stop times for stop query #1290

Merged
merged 11 commits into from
Nov 18, 2024

Conversation

amy-corson-ibigroup
Copy link
Contributor

Description:
Removes the shorter query for operators, as it was causing issues with the schedule in the nearby view.

PR Checklist:

  • Does the code follow accessibility standards (WCAG 2.1 AA Compliant)?
  • Are all languages supported (Internationalization/Localization)?
  • Are appropriate Typescript types implemented?

Copy link
Contributor

@josh-willis-arcadis josh-willis-arcadis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@josh-willis-arcadis
Copy link
Contributor

looks like snapshots need to be cleaned up

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still seeing a bug. If I go to the schedule view for a stop, then click on a stop popup on the map, I see the weird "Loading Stop...".

We might need a new approach to getting these icons?

Copy link
Collaborator

@miles-grant-ibigroup miles-grant-ibigroup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm so confused how/why this works but it totally does! Yay

@@ -86,6 +86,8 @@ function getLayerName(overlay, config, intl) {
return intl.formatMessage({ id: 'components.MapLayers.streets' })
case 'Satellite':
return intl.formatMessage({ id: 'components.MapLayers.satellite' })
case 'Stops':
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is this here?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Because the otpUi-stopsandstations layer has "Stops" as the name!
image

@amy-corson-ibigroup amy-corson-ibigroup merged commit e4eb0c8 into dev Nov 18, 2024
9 checks passed
@amy-corson-ibigroup amy-corson-ibigroup deleted the consolidate-findStopTimesForStop-query branch November 18, 2024 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants